Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional container definitions option to gateway-task submoddule #301

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Add additional container definitions option to gateway-task submoddule #301

merged 2 commits into from
Mar 11, 2024

Conversation

reskin89
Copy link
Contributor

@reskin89 reskin89 commented Mar 5, 2024

Changes proposed in this PR:

  • add new variable extra_container_definitions
  • Merge these definitions in with the rest of the container_definitions
  • This allows users to add extras like sidecars for monitoring/metrics/logging/tracing etc.

How I've tested this PR:

Deployed with the same pattern from mesh-task module.

How I expect reviewers to test this PR:

deploy a test terminating gateway with a sidecar.

Checklist:

  • [ NA ] Tests added
  • CHANGELOG entry added

@reskin89
Copy link
Contributor Author

reskin89 commented Mar 5, 2024

This references Issue #301

Ganeshrockz
Ganeshrockz approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@Ganeshrockz Ganeshrockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Waiting for the CI to go green before merging this into main

@Ganeshrockz Ganeshrockz merged commit 41d7134 into hashicorp:main Mar 11, 2024
6 of 8 checks passed
@reskin89 reskin89 mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ganeshrockz Ganeshrockz Ganeshrockz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reskin89 @Ganeshrockz